This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
add doc for migration with data move #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins retest this please |
Conky5
reviewed
Sep 4, 2019
Conky5
reviewed
Sep 4, 2019
Conky5
reviewed
Sep 4, 2019
docs/multi-instance.md
Outdated
|
|
||
| 3. Update playbook (remove `es_conf_dir`, `es_data_dirs`, `es_log_dir`, `es_pid_dir` and `es_instance_name` variables) | ||
|
|
||
| 4. Deploy ansible-role |
There was a problem hiding this comment.
Perhaps explicitly call out to use the new ansible role here.
There was a problem hiding this comment.
Ansible Galaxy command to install the new version of the role is in the example below: https://github.com/elastic/ansible-elasticsearch/pull/605/files#diff-05d70e203a6d81fe483f4556abe6750dR44
Is it what you expect?
There was a problem hiding this comment.
Yes the example is what I expect, but there is not a step in the instructions that mentions updating the role or using the new role in step 4 here.
Conky5
previously approved these changes
Sep 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #581